<html>
<head><meta charset="utf-8"><title>Searched date range misreported #82 · t-compiler/cargo-bisect-rustc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/index.html">t-compiler/cargo-bisect-rustc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html">Searched date range misreported #82</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="196794647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196794647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196794647">(May 07 2020 at 16:16)</a>:</h4>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> I believe <a href="https://github.com/rust-lang/cargo-bisect-rustc/issues/83" title="https://github.com/rust-lang/cargo-bisect-rustc/issues/83">cargo-bisect-rustc#83</a> should fix the issue you've reported</p>



<a name="196794740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196794740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196794740">(May 07 2020 at 16:17)</a>:</h4>
<p>didn't have time to properly test it, if you or someone can test it please go ahead, otherwise I'll try to properly test later</p>



<a name="196797339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196797339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196797339">(May 07 2020 at 16:39)</a>:</h4>
<p>I can probably try Saturday. Can you please @ mention me at the PR, so that the gh notification acts as a reminder for me?</p>



<a name="196804709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196804709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196804709">(May 07 2020 at 17:34)</a>:</h4>
<p>done</p>



<a name="196804755"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196804755" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196804755">(May 07 2020 at 17:34)</a>:</h4>
<p>Thanks</p>



<a name="196894895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196894895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196894895">(May 08 2020 at 13:26)</a>:</h4>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> if Santiago's changes address this, please let me know and we will push the fix with other changes that are in master over the weekend.</p>



<a name="196901991"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/196901991" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#196901991">(May 08 2020 at 14:28)</a>:</h4>
<p>Sure</p>



<a name="197164594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197164594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197164594">(May 11 2020 at 15:45)</a>:</h4>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> just pushed a different fix for this one</p>



<a name="197164599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197164599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197164599">(May 11 2020 at 15:45)</a>:</h4>
<p><a href="https://github.com/rust-lang/cargo-bisect-rustc/pull/83">https://github.com/rust-lang/cargo-bisect-rustc/pull/83</a></p>



<a name="197164652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197164652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197164652">(May 11 2020 at 15:45)</a>:</h4>
<p>let me know how can I test exactly what you're testing</p>



<a name="197176000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197176000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197176000">(May 11 2020 at 17:09)</a>:</h4>
<p>Just pushed a commit to cargo-bisect-rustc-bot-jobs to test it: <a href="https://github.com/bjorn3/cargo-bisect-rustc-bot-jobs/runs/664142625">https://github.com/bjorn3/cargo-bisect-rustc-bot-jobs/runs/664142625</a></p>



<a name="197177132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197177132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197177132">(May 11 2020 at 17:18)</a>:</h4>
<blockquote>
<p>searched toolchains nightly-2020-04-25 through nightly-2020-04-25<br>
[...]<br>
 Regression in nightly-2020-04-08</p>
</blockquote>



<a name="197185439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197185439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197185439">(May 11 2020 at 18:26)</a>:</h4>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> ouch this is another issue and I see what that is, if it's easy for you to lunch tests I may keep asking you to try otherwise if you can show me how to reproduce this would be nice too :)</p>



<a name="197187843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197187843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197187843">(May 11 2020 at 18:48)</a>:</h4>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> pushed another attempt to fix it, test it again or let me know a way of testing this</p>



<a name="197195595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197195595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197195595">(May 11 2020 at 19:49)</a>:</h4>
<p>this latest fix works, just tested your repo and reported back on the issue</p>



<a name="197288375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197288375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197288375">(May 12 2020 at 14:58)</a>:</h4>
<p><span class="user-mention" data-user-id="262810">@Chris Simpkins</span> you around?</p>



<a name="197288412"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197288412" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197288412">(May 12 2020 at 14:58)</a>:</h4>
<p>we clearly need a test suite here <span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span></p>



<a name="197294806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197294806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197294806">(May 12 2020 at 15:37)</a>:</h4>
<p>anyway, I've addressed the new problems</p>



<a name="197297527"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197297527" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197297527">(May 12 2020 at 15:55)</a>:</h4>
<p>Yep! I am here.  Definitely agree with the test suite issue and commented on your PR thread.  I am up for diving in on a refactor with test coverage in mind.  Problem on my end is time for a significant refactor right now</p>



<a name="197297759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197297759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197297759">(May 12 2020 at 15:56)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  mentioned that he began work on testing and IIRC this is in a branch of his fork of the repository.  Perhaps we can begin there and see what direction he is heading with this?  If you'd like to get together to run through how to refactor with other SH's in the project, count me in.</p>



<a name="197297936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197297936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197297936">(May 12 2020 at 15:57)</a>:</h4>
<p>yeah same happens to me, the main problem is finding time :)</p>



<a name="197298003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197298003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197298003">(May 12 2020 at 15:58)</a>:</h4>
<p>but <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span> on what you've said</p>



<a name="197299287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197299287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197299287">(May 12 2020 at 16:06)</a>:</h4>
<p>Posted this in the "Testing" thread: <a href="#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc/topic/Testing/near/197299207">https://rust-lang.zulipchat.com/#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc/topic/Testing/near/197299207</a></p>



<a name="197299530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197299530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197299530">(May 12 2020 at 16:08)</a>:</h4>
<p>I think the PR should be ready to be merged now</p>



<a name="197299700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197299700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197299700">(May 12 2020 at 16:10)</a>:</h4>
<p><span class="user-mention" data-user-id="262810">@Chris Simpkins</span> given that there are a bunch of "unrelated" things in the PR, I'd recommend reviewing commit by commit</p>



<a name="197300157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197300157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197300157">(May 12 2020 at 16:14)</a>:</h4>
<p>Will take a look this evening.  </p>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> any concerns about merging Santiago's work to address your bisect-rustc  issue?  It looks like this is sorted out and should be fixed as of his latest commit.  We are having a more general conversation about how to approach the reporting and it would be useful to hear from you what elements in the report are useful/required for your GH Actions based tool.  Separate issue, but please let us know if there is a way to better support your approach.  Perhaps something like an optional structured data format output approach that eliminates the progress reporting and only includes the test result data at the end of execution?</p>



<a name="197301880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197301880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197301880">(May 12 2020 at 16:28)</a>:</h4>
<p><span class="user-mention" data-user-id="262810">@Chris Simpkins</span> Merging is fine.</p>



<a name="197301894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197301894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197301894">(May 12 2020 at 16:28)</a>:</h4>
<p>The main problem with my bot right now is that github doesn't allow me to access github actions logs using a personal access token. I think the documentation implies that you have to create a github app to access it.</p>



<a name="197412867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched%20date%20range%20misreported%20%2382/near/197412867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Searched.20date.20range.20misreported.20.2382.html#197412867">(May 13 2020 at 13:33)</a>:</h4>
<p>This fix was merged.  We will push a release this week.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>